New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#31363 format template configure in settings #59088
#31363 format template configure in settings #59088
Conversation
…ded format_schema_rows_template setting
…_format_schema_rows_template.sh and reference
Dear @Blargian, the |
Funny fact, the |
If the commit would help, I'll create independent PR |
This is an automated comment for commit 42628fd with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
5f85653
to
276ccd3
Compare
I have restored the previous commit to not affect the autoapprove lambda. It should block changes into |
@Felixoid thanks for the heads up and also for the fix! I notice the last commits I made didn't trigger the CI to start again. Do you maybe know why? |
Do you know a joke?
Maybe we'll find another broken assumption in the CI code in the end of the day |
Рад служить! ) |
…entation and add to SettingsChanges log
set previous value as empty string for added setting rather than "none" in SettingsChangesHistory.h Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
@Avogar the last few tests are all failing on issues related to not being able to find, or remove a |
The problem is that you used filenames |
…plate_configure_in_settings
Test 02720_row_policy_column_with_dots was broken in master by accident, already fixed, so should be ok now |
…for CI failing on upgrade check
Fix failing CI upgrade check due to setting changes being listed in v24.1 when the latest version has advanced to 24.2 after merging in master branch
Tests still failing:
|
Sorry for waiting, I was on vacation. I will resolve conflicts and merge this PR when tests are finished |
No worries, thanks! Hope it was a good vacation 👍 |
Hi Clickhouse team,
I'm opening a PR for this feature. Look forward to your feedback and fixing any issues. :)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The user can now specify the template string directly in the query using
format_schema_rows_template
as an alternative toformat_template_row
. Closes #31363.Documentation entry for user-facing changes
Documentation is written - English and Russian. (То что написал на русском скорее всего есть ошибки, я не носитель русского... нужно помощь исправить пж)
docs/en/interfaces/formats.md
docs/ru/interfaces/formats.md
docs/en/operations/settings/settings-formats.md
Example usage not yet added, I can add that if needed.