Fix aggregation issue in mixed x86_64 and ARM clusters

[HarryLeeIBM]

In mixed x86-64 / ARM clusters, distributed aggregation queries return incorrect results due to different hashes generated (StringHashTableHash) on both platforms.

The issue can be reproduced by the sql statements in "tests/integration/test_backward_compatability/test_short_strings_aggregation.py".

The fix is to use aarch64's __crc32cd() intrinsic which returns the same hash results as the hash on x86_64.

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed wrong aggregation results in mixed x86_64 and ARM clusters.

[robot-clickhouse-ci-1]

This is an automated comment for commit 94a79c0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker server and keeper images	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Docs check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Fast tests	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

[HarryLeeIBM]

@rschu1ze, could you or any ClickHouse team member review this PR? thanks!
plus, I believe the errors in CI is irrelevant to the fix.

[rschu1ze]

Looking at

• https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_crc32_u64&ig_expand=1420,1421,1420 (l. 69)
• https://docs.unity3d.com/Packages/com.unity.burst@1.6/api/Unity.Burst.Intrinsics.Arm.Neon.__crc32cd.html (l. 78)
• and https://en.wikipedia.org/wiki/Cyclic_redundancy_check

it looks like different generator polynoms are used on x86_64 and ARM?

[HarryLeeIBM]

@rschu1ze, the crc32c algorithm uses 0x11EDC6F41. The polynomial 0x04C11DB7 in Unity document for __crc32cd is a "copy and paste" mistake, if you check Unity's __crc32d, it has also 0x04C11DB7 :-).

BTW, is it good to get it merged now? Thanks!

[rschu1ze]

Omg :-) Thanks for checking.

[rschu1ze]

Branch master is currently in a freeze due to test failures, I'll merge when it's open again. Thanks for the patch!