New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable parallel replicas JOIN with CTE (not analyzer) #59239
Disable parallel replicas JOIN with CTE (not analyzer) #59239
Conversation
This is an automated comment for commit a6de4a2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
8dfa608
to
b7703a4
Compare
b7703a4
to
176d8be
Compare
Failures is unrelated |
@Algunenano It looks there is an issue with the code - https://s3.amazonaws.com/clickhouse-test-reports/59375/35d133947432fe2bfb901beba2678bdd40c71826/ast_fuzzer__ubsan_/report.html |
Thank you! Adding a patch to fix it |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
Disable parallel replicas when doing a JOIN between a mergetree and a CTE. It never worked correctly. In the best case you get a missing table error or an exception due to mixing different tables, in the worse case you read from different tables than expected and get an incorrect result.
Partially reverts / reimplements #58133 cc @devcrafter
The analyzer already has a better implementation.