Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with intDiv for decimal arguments #59243

Merged
merged 13 commits into from Feb 19, 2024

Conversation

yariks5s
Copy link
Member

@yariks5s yariks5s commented Jan 25, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes bug with for function intDiv with decimal arguments. Fixes #56414.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jan 25, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jan 25, 2024

This is an automated comment for commit cfa198c with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@alexey-milovidov alexey-milovidov changed the title Fix bug with divInt for decimal arguments Fix bug with intDiv for decimal arguments Jan 26, 2024
@Avogar Avogar self-assigned this Jan 26, 2024
@yariks5s yariks5s requested a review from Avogar January 31, 2024 10:50
@Avogar
Copy link
Member

Avogar commented Feb 14, 2024

Seems like 00700_decimal_compare.sql test crashed server in fasttest

Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
@yariks5s yariks5s requested a review from Avogar February 19, 2024 11:45
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
@yariks5s yariks5s merged commit 491a4cd into ClickHouse:master Feb 19, 2024
34 of 120 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 19, 2024
Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Mar 1, 2024
…h_decimal"

This reverts commit 491a4cd, reversing
changes made to f10a886.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why intDivOrZero result is decimal
4 participants