New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fasttest by pinning pip dependencies #59256
Conversation
This is an automated comment for commit 92d96c4 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
I'm also looking in parallel into updating all of the dependencies (since newer Python requires newer deps) with:
Waiting on CI to see what works |
Great, I also though about pinning everything! Is the PR in some private repo? Or there is no PR yet? |
Yes, but I'll bring it here if the CI is ok. |
As for adding pyarrow, it will increase image size to 100MB, and this is the thing that I was trying to avoid (maybe pandas will eventually remove requirement for pyarrow, since it seems that some people are unhappy) |
You are right, I didn't check. Let's try |
After image update it prints the following warning: /ClickHouse/tests/queries/0_stateless/01558_ttest_scipy.python:5: DeprecationWarning: Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0), (to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries) but was not found to be installed on your system. If this would cause problems for you, please provide us feedback at pandas-dev/pandas#54466 Pyarrow can be added as well, but according to the comment in the issue it bloats the image size 170%, so let's simply downgrade it for now and see how that issue will be resolved (or the warning could be suppressed of course). And pin other dependencies as well to avoid further failures. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Sure, I've adjusted the patch. And I've tested it locally image had been successfully built, let's see what CI will say. |
Fast test passed |
…84f780e083dbdf797aaa2815467f5 Cherry pick #59256 to 23.3: Fix fasttest by pinning pip dependencies
…84f780e083dbdf797aaa2815467f5 Cherry pick #59256 to 23.8: Fix fasttest by pinning pip dependencies
…b84f780e083dbdf797aaa2815467f5 Cherry pick #59256 to 23.10: Fix fasttest by pinning pip dependencies
…b84f780e083dbdf797aaa2815467f5 Cherry pick #59256 to 23.11: Fix fasttest by pinning pip dependencies
…b84f780e083dbdf797aaa2815467f5 Cherry pick #59256 to 23.12: Fix fasttest by pinning pip dependencies
Backport #59256 to 23.12: Fix fasttest by pinning pip dependencies
@Algunenano, the backports are unnecessary, actually. Fast tests don't run for release branches anyhow |
After image update it prints the following warning:
Pyarrow can be added as well, but according to the comment in the issue it bloats the image size 170%, so let's simply downgrade it for now and see how that issue will be resolved (or the warning could be suppressed of course).
Changelog category (leave one):