New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-string arguments in concatWithSeparator()
#59341
Merged
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
rschu1ze:non-string-concat-with-separator
Jan 30, 2024
Merged
Allow non-string arguments in concatWithSeparator()
#59341
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
rschu1ze:non-string-concat-with-separator
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
changed the title
Non string concat with separator
Allow non-string arguments in Jan 29, 2024
concatWithSeparator()
robot-clickhouse-ci-2
added
the
pr-improvement
Pull request with some product improvements
label
Jan 29, 2024
This is an automated comment for commit c2b7d20 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
alexey-milovidov
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for concatinating arbitrary types in function
concatWithSeparator()
. This is follow-up for #56540, basically to achieve consistency betweenconcat*()
functions.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Function
concatWithSeparator()
now supports arbitrary argument types (instead of onlyString
andFixedString
arguments). For example,SELECT concatWithSeparator('.', 'number', 1)
now returnsnumber.1
.