Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fuzzing to ASTLiterals #59383

Merged
merged 6 commits into from Feb 5, 2024
Merged

Conversation

Algunenano
Copy link
Member

@Algunenano Algunenano commented Jan 30, 2024

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Add some fuzzing to ASTLiterals

Documentation entry for user-facing changes

For ASTLiteral under ASTExpressionList try adding or removing:

  • Cast to FixedString if String (only addition, not removal).
  • Cast to Nullable.
  • Cast to LowCardinality
  • materialize()

This is assuming those nodes are not being referenced by other ones and can be replaced in the query

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-build Pull request with build/testing/packaging improvement label Jan 30, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jan 30, 2024

This is an automated comment for commit 7be91e6 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@Algunenano Algunenano marked this pull request as draft January 30, 2024 17:40
@Algunenano
Copy link
Member Author

Looks like changing nodes is not safe. Adding an assert like chassert(expr_list.children[i].use_count() == 1); detects the problem, so I need to find who else keeps a reference and how to change it (if possible)

@novikd novikd self-assigned this Jan 30, 2024
@Algunenano Algunenano marked this pull request as ready for review January 31, 2024 11:04
@Algunenano
Copy link
Member Author

Unrelated failures. Kind of sad the fuzzer hasn't found anything (yet) but we can see it's working:

SELECT toDateTime(toLowCardinality('2017-06-28 12:01:01')) < toDate('2017-07-01')

Got boring AST
Fuzzing step 69 out of 1000

SELECT toDateTime(toLowCardinality('2017-06-28 12:01:01')) < toDate('2017-07-01')

Got boring AST
Fuzzing step 70 out of 1000

SELECT toDateTime(toLowCardinality(toNullable(toFixedString('2017-06-28 12:01:01', 19)))) < toDate('2017-07-01')

Query succeeded, using this AST as a start
Fuzzing step 71 out of 1000

SELECT toDateTime(toLowCardinality(toNullable(toFixedString('2017-06-28 12:01:01', 19)))) < toDate('2017-07-01')

"toFixedString", std::make_shared<ASTLiteral>(value), std::make_shared<ASTLiteral>(static_cast<UInt64>(value.size())));
}

if (fuzz_rand() % 11 == 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have another method that will remove toNullable and other functions? Take one child from function as ExpressionList. Otherwise it will always converge to have all literals converted to functions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do, but it should be possible to add it for the functions added here (if they are a function with one of the names and only one child, randomly replace it with the child)

@Algunenano
Copy link
Member Author

Seems like it works both ways:

SELECT
    76,
    x
FROM table_1__fuzz_5
SETTINGS additional_table_filters = {'table_1':'x != 2'}

Got boring AST
Fuzzing step 60 out of 1000

SELECT
    toLowCardinality(toNullable(76)),
    x
FROM table_1__fuzz_5
SETTINGS additional_table_filters = {'table_1':'x != 2'}

Query succeeded, using this AST as a start
Fuzzing step 61 out of 1000

SELECT
    toLowCardinality(toNullable(76)),
    x
FROM table_1__fuzz_3
SETTINGS additional_table_filters = {'table_1':'x != 2'}

Query succeeded, using this AST as a start
Fuzzing step 62 out of 1000

SELECT
     toNullable(76),
    x
FROM table_1__fuzz_1
SETTINGS additional_table_filters = {'table_1':'x != 2'}

Query succeeded, using this AST as a start
Fuzzing step 63 out of 1000

SELECT
     toNullable(76),
    x
FROM table_1__fuzz_5
SETTINGS additional_table_filters = {'table_1':'x != 2'}

Query succeeded, using this AST as a start
Fuzzing step 64 out of 1000

@Algunenano Algunenano merged commit 08c1799 into ClickHouse:master Feb 5, 2024
234 of 258 checks passed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants