New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stacktraces for binaries without debug symbols #59444
Conversation
This is an automated comment for commit ea720e3 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
can we create a test for it? |
I thought about this, but I don't want to strip binaries (or/and play with debug symbols in tests, plus fasttest has different type of binary then the packages has) in tests. But I think something like this will be OK - |
ce43c6c
to
ba98325
Compare
|
During refactoring in ClickHouse#58610 it had been broken since itassumes that the information about file is always available, otherwise it will not print symbol name. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
ba98325
to
ea720e3
Compare
|
It's definitely fixed. Let's spin a new patch release today |
#59475 azure sanitizer |
…8ab9264cbe1d8026118d40ce7d039 Cherry pick #59444 to 24.1: Fix stacktraces for binaries without debug symbols
Backport #59444 to 24.1: Fix stacktraces for binaries without debug symbols
During refactoring in #58610 it had been broken since itassumes that the information about file is always available, otherwise it will not print symbol name.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix stacktraces for binaries without debug symbols
Fixes: #59438 (cc @nickitat)