Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ASTAlterCommand::formatImpl in case of column specific settings… #59445

Conversation

antaljanosbenjamin
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix formatting of alter commands in case of column specific settings

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Jan 31, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jan 31, 2024

This is an automated comment for commit 1faa04d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@antaljanosbenjamin antaljanosbenjamin force-pushed the fix-formatting-alter-queries-with-modify-column-settings branch 2 times, most recently from aa4f0b3 to a8cd30e Compare January 31, 2024 20:32
@evillique evillique self-assigned this Jan 31, 2024
@maxknv maxknv force-pushed the fix-formatting-alter-queries-with-modify-column-settings branch from 5a80504 to d56d0c3 Compare February 1, 2024 12:53
@antaljanosbenjamin antaljanosbenjamin force-pushed the fix-formatting-alter-queries-with-modify-column-settings branch from d56d0c3 to a7ccd7e Compare February 1, 2024 14:45
@antaljanosbenjamin antaljanosbenjamin force-pushed the fix-formatting-alter-queries-with-modify-column-settings branch from a7ccd7e to a093577 Compare February 1, 2024 14:50
@antaljanosbenjamin
Copy link
Member Author

@canhld94 As you are the original author, feel free to have a look at this, maybe you can spot something that I missed.

@canhld94
Copy link
Contributor

canhld94 commented Feb 2, 2024

@antaljanosbenjamin thank you for fixing this. I don't have further comment.

@antaljanosbenjamin
Copy link
Member Author

The integration test is flaky (see), while the integration test failed because the cleanup of replicated database tests are flaky in general (see).

@antaljanosbenjamin antaljanosbenjamin merged commit 59dcd22 into master Feb 5, 2024
247 of 266 checks passed
@antaljanosbenjamin antaljanosbenjamin deleted the fix-formatting-alter-queries-with-modify-column-settings branch February 5, 2024 16:44
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 7, 2024
…fbc83fb2c87a272a9adf83fe09f20

Cherry pick #59445 to 24.1: Fix `ASTAlterCommand::formatImpl` in case of column specific settings…
robot-clickhouse added a commit that referenced this pull request Feb 7, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 7, 2024
robot-ch-test-poll added a commit that referenced this pull request Feb 8, 2024
Backport #59445 to 24.1: Fix `ASTAlterCommand::formatImpl` in case of column specific settings…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default v24.1-must-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants