Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SELECT * FROM [...] ORDER BY ALL with Analyzer #59462

Merged
merged 4 commits into from Feb 2, 2024

Conversation

zhongyuankai
Copy link
Contributor

@zhongyuankai zhongyuankai commented Feb 1, 2024

Fixes: #59151

Example: https://fiddle.clickhouse.com/d8604718-4578-40a1-a81c-604fe7c9091c

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

SELECT * FROM [...] ORDER BY ALL SETTINGS allow_experimental_analyzer = 1 now works.

@rschu1ze rschu1ze self-assigned this Feb 1, 2024
@rschu1ze rschu1ze changed the title order by all doesn't work for select * Fix SELECT * [...] ORDER BY ALL Feb 1, 2024
@rschu1ze rschu1ze changed the title Fix SELECT * [...] ORDER BY ALL Fix SELECT * [...] ORDER BY ALL with analyzer Feb 1, 2024
@rschu1ze rschu1ze changed the title Fix SELECT * [...] ORDER BY ALL with analyzer Fix SELECT * [...] ORDER BY ALL with Analyzer Feb 1, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 1, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Feb 1, 2024

This is an automated comment for commit 90c2bf6 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label Feb 1, 2024
@rschu1ze rschu1ze changed the title Fix SELECT * [...] ORDER BY ALL with Analyzer Fix SELECT * FROM [...] ORDER BY ALL with Analyzer Feb 2, 2024
@rschu1ze rschu1ze merged commit bf0733b into ClickHouse:master Feb 2, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surprising behavior of ORDER BY ALL in some cases
3 participants