New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate key for clickhouse_remove_objects_capability #59495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll4
added
the
pr-improvement
Pull request with some product improvements
label
Feb 1, 2024
This is an automated comment for commit 6e085c7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
CheSema
force-pushed
the
chesema-remove-objects-capability
branch
2 times, most recently
from
February 1, 2024 21:24
bcb61b3
to
b7dc69d
Compare
davenger
approved these changes
Feb 2, 2024
CheSema
force-pushed
the
chesema-remove-objects-capability
branch
2 times, most recently
from
February 5, 2024 12:24
7ba95da
to
76753bf
Compare
I have doubts here according PlainS3. Need to check it works right with PlainS3 before merge. |
CheSema
force-pushed
the
chesema-remove-objects-capability
branch
from
March 5, 2024 13:02
76753bf
to
6e085c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
instead using a constant key, now object storage generates key for determining remove objects capability.