New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MAX use the same rules as permutation for complex types #59498
Conversation
This is an automated comment for commit d9c7807 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Integration failures related to #59509. I'll update with master again just in case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one thing I am not sure about.
…317ac131240e347775d51fe08dc99 Cherry pick #59498 to 24.1: Make MAX use the same rules as permutation for complex types
Backport #59498 to 24.1: Make MAX use the same rules as permutation for complex types
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
For complex types, make sure MIN and MAX work the same way as
ORDER BY LIMIT 1
when dealing with NaN or NULL values in their inner values.Closes #59492
Note this doesn't apply to Float types, where the presence of NaN leads to undefined behaviour (either NaN or the lowest/highest non NaN value will be returned).