Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect result of arrayElement / map[] on empty value #59594

Merged
merged 3 commits into from Feb 6, 2024

Conversation

Algunenano
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix incorrect result of arrayElement / map[] on empty value

Documentation entry for user-facing changes

Introduced in #55957. The values stored are copied using memcpySmallAllowReadWriteOverflow15 which requires the source to have at least 15 extra bytes at the end which might be copied into the target. zero_buf did not respect that.

Closes #59402

@Algunenano Algunenano added bug Confirmed user-visible misbehaviour in official release pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Feb 5, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 5, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Feb 5, 2024

This is an automated comment for commit c858e2e with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@evillique evillique self-assigned this Feb 5, 2024
@Algunenano Algunenano removed the bug Confirmed user-visible misbehaviour in official release label Feb 6, 2024
@Algunenano Algunenano merged commit 79d9129 into ClickHouse:master Feb 6, 2024
7 of 9 checks passed
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 6, 2024
…27ce823ecdd3c2280627bfd2d4e54a

Cherry pick #59594 to 23.11: Fix incorrect result of arrayElement / map[] on empty value
robot-clickhouse added a commit that referenced this pull request Feb 6, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 6, 2024
…27ce823ecdd3c2280627bfd2d4e54a

Cherry pick #59594 to 23.12: Fix incorrect result of arrayElement / map[] on empty value
robot-clickhouse added a commit that referenced this pull request Feb 6, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Feb 6, 2024
…7ce823ecdd3c2280627bfd2d4e54a

Cherry pick #59594 to 24.1: Fix incorrect result of arrayElement / map[] on empty value
robot-clickhouse added a commit that referenced this pull request Feb 6, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 6, 2024
robot-clickhouse added a commit that referenced this pull request Feb 6, 2024
Backport #59594 to 24.1: Fix incorrect result of arrayElement / map[] on empty value
robot-ch-test-poll added a commit that referenced this pull request Feb 6, 2024
Backport #59594 to 23.12: Fix incorrect result of arrayElement / map[] on empty value
Algunenano added a commit that referenced this pull request Feb 6, 2024
Backport #59594 to 23.11: Fix incorrect result of arrayElement / map[] on empty value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

23.11+ Grouping is not finalized when a Map element that does not exist in a Map
4 participants