New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect result of arrayElement / map[] on empty value #59594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algunenano
added
bug
Confirmed user-visible misbehaviour in official release
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Feb 5, 2024
robot-clickhouse-ci-2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 5, 2024
This is an automated comment for commit c858e2e with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page Successful checks
|
evillique
approved these changes
Feb 5, 2024
Algunenano
removed
the
bug
Confirmed user-visible misbehaviour in official release
label
Feb 6, 2024
This was referenced Feb 6, 2024
Closed
Closed
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 6, 2024
…27ce823ecdd3c2280627bfd2d4e54a Cherry pick #59594 to 23.11: Fix incorrect result of arrayElement / map[] on empty value
This was referenced Feb 6, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 6, 2024
…27ce823ecdd3c2280627bfd2d4e54a Cherry pick #59594 to 23.12: Fix incorrect result of arrayElement / map[] on empty value
This was referenced Feb 6, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 6, 2024
…7ce823ecdd3c2280627bfd2d4e54a Cherry pick #59594 to 24.1: Fix incorrect result of arrayElement / map[] on empty value
robot-clickhouse-ci-1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Feb 6, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Feb 6, 2024
Backport #59594 to 24.1: Fix incorrect result of arrayElement / map[] on empty value
robot-ch-test-poll
added a commit
that referenced
this pull request
Feb 6, 2024
Backport #59594 to 23.12: Fix incorrect result of arrayElement / map[] on empty value
Algunenano
added a commit
that referenced
this pull request
Feb 6, 2024
Backport #59594 to 23.11: Fix incorrect result of arrayElement / map[] on empty value
conner
added a commit
to vantage-sh/homebrew-clickhouse
that referenced
this pull request
Feb 19, 2024
conner
added a commit
to vantage-sh/homebrew-clickhouse
that referenced
this pull request
Feb 19, 2024
conner
added a commit
to vantage-sh/homebrew-clickhouse
that referenced
this pull request
Feb 19, 2024
conner
added a commit
to vantage-sh/homebrew-clickhouse
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
Introduced in #55957. The values stored are copied using
memcpySmallAllowReadWriteOverflow15
which requires the source to have at least 15 extra bytes at the end which might be copied into the target.zero_buf
did not respect that.Closes #59402