New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce peak memory while executing filter #59698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-performance
Pull request with some performance improvements
label
Feb 7, 2024
This is an automated comment for commit 0c7d12c with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
jsc0218
approved these changes
Feb 13, 2024
probably update once so less check fails. |
taiyang-li
changed the title
Trivial optimize on column filter
Reduce peak memory while executing column filter
Feb 19, 2024
taiyang-li
changed the title
Reduce peak memory while executing column filter
Reduce peak memory while executing filter
Feb 19, 2024
Peak memory can be reduced to 44% of the original create table test_filter engine = Memory as select * from generateRandom('t Tuple(a Decimal256(3), b Float64, c Int256), i8 Int8, i16 Int16', 1, 19, 2) limit 100000000;
select * from test_filter where i16 > 100 format Null;
Old: Peak memory usage: 182.95 MiB.
New: Peak memory usage: 80.96 MiB. |
@jsc0218 is it ok to merge it now? Thanks! |
jsc0218
added a commit
that referenced
this pull request
Mar 13, 2024
Fix an error in previous opt: #59698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-performance
Pull request with some performance improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Trivial optimize on column filter. Avoid those filter columns whoes underlying data type is not number being filtered with
result_size_hint = -1
. Peak memory can be reduced to 44% of the original in some cases.