New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sql created named collections in Kafka Storage for librdkafka settings #59710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myrrc
suggested changes
Feb 12, 2024
GrigoryPervakov
force-pushed
the
master
branch
from
February 20, 2024 12:15
4492bc6
to
9f745bb
Compare
myrrc
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GrigoryPervakov
force-pushed
the
master
branch
from
February 26, 2024 15:47
9f745bb
to
ad74e63
Compare
kssenii
added
the
can be tested
Allows running workflows for external contributors
label
Feb 26, 2024
robot-ch-test-poll3
added
the
pr-improvement
Pull request with some product improvements
label
Feb 26, 2024
This is an automated comment for commit d3b82ab with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
kssenii
reviewed
Feb 26, 2024
GrigoryPervakov
force-pushed
the
master
branch
3 times, most recently
from
February 26, 2024 19:26
c97e306
to
866c01e
Compare
kssenii
approved these changes
Feb 27, 2024
GrigoryPervakov
force-pushed
the
master
branch
from
February 27, 2024 18:37
ee90c86
to
d3b82ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Unify xml and sql created named collection behaviour in kafka storage.
Kafka storage have two types of parameters: storage parameters iteself and settings that would be passed to librdkafka.
Before changes storage paramets applied in both cases, but kafka settings loaded only if named collection was created with xml config.
Changes unifies named collection access and as a bonus allows use new xml named collection without server restart.
Example:
Consider following config
And queries like
Before changes table kafka_sql would not apply first 4 settings and would be unable to auth.
And also it wouldn't read default config, because of specified named collection, so right now kafka storage with sql created named collection is almost not configurable.