New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rabbitmq: fix having neither acked nor nacked messages #59775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 8, 2024
This is an automated comment for commit 5ef4a30 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
jkartseva
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some comments.
kssenii
force-pushed
the
rabbitmq-fix-possible-channel-ack-timeout
branch
from
February 14, 2024 14:25
5762116
to
8fe9ede
Compare
jkartseva
approved these changes
Feb 15, 2024
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Feb 21, 2024
kssenii
changed the title
rabbitmq: fix possible channel error state
rabbitmq: fix having neigher acked nor nacked messages
Feb 22, 2024
kssenii
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Feb 22, 2024
kssenii
changed the title
rabbitmq: fix having neigher acked nor nacked messages
rabbitmq: fix having neither acked nor nacked messages
Feb 22, 2024
This was referenced Feb 22, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Feb 22, 2024
…3a0795058314237d37c935f75f783 Cherry pick #59775 to 24.1: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse
added a commit
that referenced
this pull request
Feb 22, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 22, 2024
…3a0795058314237d37c935f75f783 Cherry pick #59775 to 23.8: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse
added a commit
that referenced
this pull request
Feb 22, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 22, 2024
…33a0795058314237d37c935f75f783 Cherry pick #59775 to 23.11: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse
added a commit
that referenced
this pull request
Feb 22, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 22, 2024
…33a0795058314237d37c935f75f783 Cherry pick #59775 to 23.12: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse
added a commit
that referenced
this pull request
Feb 22, 2024
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Feb 22, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Feb 23, 2024
Backport #59775 to 24.1: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Feb 23, 2024
Backport #59775 to 23.11: rabbitmq: fix having neither acked nor nacked messages
robot-clickhouse
added a commit
that referenced
this pull request
Feb 23, 2024
Backport #59775 to 23.12: rabbitmq: fix having neither acked nor nacked messages
alexey-milovidov
added a commit
that referenced
this pull request
Feb 29, 2024
Backport #59775 to 23.8: rabbitmq: fix having neither acked nor nacked messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix having neigher acked nor nacked messages. If exception happens during read-write phase, messages will be nacked.