New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StorageURL doing some of the query execution in single thread #59833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 10, 2024
This is an automated comment for commit b5fd68a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
alexey-milovidov
approved these changes
Feb 10, 2024
robot-ch-test-poll4
added
the
submodule changed
At least one submodule changed in this PR.
label
Feb 10, 2024
robot-clickhouse
removed
the
submodule changed
At least one submodule changed in this PR.
label
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed queries that read a Parquet file over HTTP (url()/URL()) executing in one thread instead of max_threads.
#58353 accidentally changed num_streams behavior in StorageURL. It's supposed to create
min(num_streams, num_files)
StorageURLSource-s, then resize the pipeline to num_streams, so that the rest of query execution is multithreaded even if there's only one file to read.Before the fix:
After the fix:
Old version before #58353:
Benchmark: https://pastila.nl/?cafebabe/6ae75c0a672707eb39dee0de241cb628.html#GhbniwKxvMQSvZPyWQgL5w==