New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3queue: fix uninitialized value #59897
Conversation
This is an automated comment for commit d008ee7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Please add a test (I guess it can be tested with detach/attach table) |
No, it fails only if upgraded from an older clickhouse server version. Will add a test. |
Ah, okay, then the test will not be so useful |
if (json->has("s3queue_total_shards_num")) | ||
s3queue_total_shards_num = json->getValue<UInt64>("s3queue_total_shards_num"); | ||
else | ||
s3queue_total_shards_num = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, put default initialization in the class.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed uninitialized value in s3 queue, which happened during upgrade to a new version if table had Ordered mode and resulted in an error "Existing table metadata in ZooKeeper differs in s3queue_processing_threads_num setting".