New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rewrite sum() to count() if return value differs in analyzer #59926
Merged
novikd
merged 2 commits into
ClickHouse:master
from
azat:analyzer/NormalizeCountVariantsVisitor-fix
Feb 16, 2024
Merged
Do not rewrite sum() to count() if return value differs in analyzer #59926
novikd
merged 2 commits into
ClickHouse:master
from
azat:analyzer/NormalizeCountVariantsVisitor-fix
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
robot-ch-test-poll1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 13, 2024
This is an automated comment for commit 504a2dd with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Ok. Something strange is found by Fuzzer. |
novikd
approved these changes
Feb 14, 2024
novikd
reviewed
Feb 14, 2024
azat
force-pushed
the
analyzer/NormalizeCountVariantsVisitor-fix
branch
from
February 15, 2024 11:40
39ec88b
to
d2d58bf
Compare
v2: fix for LowCardinality Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
analyzer/NormalizeCountVariantsVisitor-fix
branch
from
February 15, 2024 11:41
d2d58bf
to
504a2dd
Compare
azat
changed the title
Do not rewrite sum(Nullable()) to count()
Do not rewrite sum() to count() if return value differs in analyzer
Feb 15, 2024
novikd
approved these changes
Feb 15, 2024
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
analyzer
Issues and pull-requests related to new analyzer
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not rewrite sum() to count() if return value differs in analyzer
Fixes: #59919
Cc: @kitaisreal