S3Express support

[nickitat]

Changelog category:

• New Feature

Changelog entry:

Implemented support for S3Express buckets.

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[robot-ch-test-poll4]

This is an automated comment for commit f9d1c57 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

[nickitat]

Integration tests (tsan) [2/6] - smth with s3queue
Stateless tests (tsan) [1/5] - #60625

[vitlibar]

[x] Documentation is written (mandatory for new features)

What do you mean?

[vitlibar]

This namespace seems to be redundant and it seems it makes the code less clear.
These functions are very simple and it seems you can just do what you want directly without these functions.

[nickitat]

These functions are very simple and it seems you can just do what you want directly without these functions.

yep, let me explain what problem I tried to solve.
in Client::doRequest() we do

if (client_settings.is_s3express_bucket)
    request.setIsS3ExpressBucket();

that basically sets checksum algorithm. and then (much higher on the stack) in WriteBufferFromS3 we will have to set the appropriate checksum. and because there are multiple checksum algorithms (and consequently multiple SetChecksum* methods) it looked really random to just call some crc-related methods out of nowhere. so I thought that since we're gonna use only one algorithm inside CH codebase anyway - it would be a good idea to abstract it away inside some class or just a namespace.

if you still think it doesn't worth it - i'm ok to get rid of it.

[vitlibar]

This template function looks like a bit of overcomplication. Which actual types of requests need this function SetChecksumAlgorithm(Model::ChecksumAlgorithm::CRC32) to be called? Only UploadPartRequest? Why can't you just call it immediately after calling req.SetChecksumCRC32() ?

[nickitat]

to my understanding it is needed for all requests with body. e.g. also CreateMultipartUploadRequest, PutObjectRequest.

[vitlibar]

BTW what is S3Express? And why it requires checksum to be sent?

[nickitat]

[x] Documentation is written (mandatory for new features)

What do you mean?

I mean the linked pr to docs: ClickHouse/clickhouse-docs#2069

[nickitat]

BTW what is S3Express? And why it requires checksum to be sent?

https://aws.amazon.com/s3/storage-classes/express-one-zone/
idk why, but it is how the new tier works.