New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix INSERT into SQLite with single quote (by escaping single quotes with a quote instead of backslash) #60015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Feb 15, 2024
This is an automated comment for commit f10fc95 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
azat
changed the title
Fix INSERT into SQLite with single quote (by properly escaping single quotes with a quote instead of backslash)
Fix INSERT into SQLite with single quote (by escaping single quotes with a quote instead of backslash)
Feb 15, 2024
kssenii
reviewed
Feb 15, 2024
azat
force-pushed
the
values-quote-escape
branch
from
February 15, 2024 11:46
a8df218
to
1b1c1ef
Compare
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Previously it leads to syntax error, due to incorrect escaping of single quotes for SQLite, "\'" had been used instead of "''" So set output_format_values_escape_quote_with_quote=true for SQLite to fix this. v2: prepare modified Context for writing on storage creation Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
values-quote-escape
branch
from
February 15, 2024 11:47
1b1c1ef
to
f10fc95
Compare
kssenii
approved these changes
Feb 15, 2024
alexey-milovidov
approved these changes
Feb 19, 2024
|
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix INSERT into SQLite with single quote (by properly escaping single quotes with a quote instead of backslash)