Fix finished_mutations_to_keep=0 for MergeTree (as docs says 0 is to keep everything)

[azat]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix finished_mutations_to_keep=0 for MergeTree (as docs says 0 is to keep everything)

[robot-ch-test-poll3]

This is an automated comment for commit 3c08e19 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Unit tests	Runs the unit tests for different release types	❌ error

[azat]

Bugfix validation — New test(s) failed to reproduce a bug

• Fix bugfix check (due to unknown commit_logs_cache_size_threshold) #60375

Integration tests (release) [3/4] — fail: 1, passed: 641

• test_replicated_zero_copy_projection_mutation/test.py::test_all_projection_files_are_dropped_when_part_is_dropped - since now mutations are note removed on DROP PART. I've updated the test

[antaljanosbenjamin]

There are a lot of noise regarding to unrelated issues (e.g. the io_uring stuff), so let merge a master when you want to merge to trigger a new run. This change is simple, but might affect important parts, so it is better to have a another run in my opinion.

[antaljanosbenjamin]

Apart from the stress test all the failures are flaky tests:

• 02782_uniq_exact_parallel_merging_bug CI DB
• 01459_manual_write_to_replicas CI DB
• 01171_mv_select_insert_isolation_long CI DB, failed twice

[azat]

So, is there anything else left?

UPD: will do a rebase to fix CI

[antaljanosbenjamin]

This PR looks okay, I will merge it soon. Sorry for not merging yet, but our CI started to show strange errors and I was worried to merge things without figuring those things out first.

[antaljanosbenjamin]

Unit tests failed with:

[ RUN      ] ConnectionPoolTest.NoReceiveCall
/build/base/poco/Foundation/src/ThreadPool.cpp:188:14: runtime error: member call on address 0x555599f3d050 which does not point to an object of type 'Poco::Runnable'
0x555599f3d050: note: object has invalid vptr
 00 00 00 00  50 dc c7 8c 55 55 00 00  01 00 00 00 00 00 00 00  d0 9a f9 99 55 55 00 00  00 00 00 00

I doubt this is connected to this PR. I will open an issue about this.

02784_parallel_replicas_automatic_decision_join is flaky #60625.

02908_many_requests_to_system_replicas was recently fixed #57443.