Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dictionaries for modification with unlocked ExternalLoader::mutex #6011

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Check dictionaries for modification with unlocked ExternalLoader::mutex #6011

merged 2 commits into from
Jul 17, 2019

Conversation

vitlibar
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Fix hanging when condition in invalidate_query depends on a dictionary.

Category (leave one):

  • Bug Fix

@vitlibar vitlibar changed the title Check dictionaries for modification with unlocked ExternalLoader::mutex [WIP] Check dictionaries for modification with unlocked ExternalLoader::mutex Jul 15, 2019
@vitlibar vitlibar force-pushed the check-dictionaries-for-modification-with-unlocked-mutex branch from 64d5869 to 1b54c38 Compare July 15, 2019 16:07
alexey-milovidov
alexey-milovidov approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

PS. Please make a test if possible.

@vitlibar vitlibar force-pushed the check-dictionaries-for-modification-with-unlocked-mutex branch from 1b54c38 to 96f7a41 Compare July 16, 2019 18:04
@vitlibar vitlibar changed the title [WIP] Check dictionaries for modification with unlocked ExternalLoader::mutex Check dictionaries for modification with unlocked ExternalLoader::mutex Jul 16, 2019
@vitlibar vitlibar force-pushed the check-dictionaries-for-modification-with-unlocked-mutex branch from 96f7a41 to 38c3889 Compare July 17, 2019 08:41
@vitlibar vitlibar merged commit a01fa50 into ClickHouse:master Jul 17, 2019
@vitlibar vitlibar deleted the check-dictionaries-for-modification-with-unlocked-mutex branch July 17, 2019 13:06
@alexey-milovidov alexey-milovidov added the pr-bugfix Pull request with bugfix, not backported by default label Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees
No one assigned
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitlibar @alexey-milovidov @tavplubix