New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TableEngineGrant_version2 #60117
Merged
jsc0218
merged 18 commits into
ClickHouse:master
from
jsc0218:TableEngineGrant_version2
Apr 18, 2024
Merged
TableEngineGrant_version2 #60117
jsc0218
merged 18 commits into
ClickHouse:master
from
jsc0218:TableEngineGrant_version2
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated comment for commit 6e5afb8 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
jsc0218
added
the
can be tested
Allows running workflows for external contributors
label
Feb 19, 2024
@vitlibar Would you mind to take a look again? This version is implemented according to the discussion in the previous one. The code is simplified and extensible now. |
vitlibar
reviewed
Mar 12, 2024
vitlibar
reviewed
Mar 12, 2024
jsc0218
force-pushed
the
TableEngineGrant_version2
branch
5 times, most recently
from
March 16, 2024 22:14
eb18e6e
to
c5dc35e
Compare
vitlibar
reviewed
Apr 13, 2024
vitlibar
reviewed
Apr 13, 2024
vitlibar
reviewed
Apr 14, 2024
vitlibar
reviewed
Apr 14, 2024
tests/integration/test_dictionaries_ddl/configs/user_default.xml
Outdated
Show resolved
Hide resolved
vitlibar
reviewed
Apr 14, 2024
tests/queries/0_stateless/02232_allow_only_replicated_engine.sh
Outdated
Show resolved
Hide resolved
vitlibar
reviewed
Apr 14, 2024
vitlibar
reviewed
Apr 14, 2024
jsc0218
force-pushed
the
TableEngineGrant_version2
branch
2 times, most recently
from
April 17, 2024 00:11
3e34eee
to
a1e3a4a
Compare
jsc0218
force-pushed
the
TableEngineGrant_version2
branch
2 times, most recently
from
April 18, 2024 01:48
c9c23cc
to
80fa1ab
Compare
vitlibar
approved these changes
Apr 18, 2024
Merged
via the queue into
ClickHouse:master
with commit Apr 18, 2024
7525b2a
225 of 234 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Apr 18, 2024
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-feature
Pull request with new product feature
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #38316
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
table engine is grantable now, and it won't affect existing users behavior
Documentation entry for user-facing changes
It follows the GRANT syntax, for example,