Copy S3 file GCP fallback to buffer copy

[kitaisreal]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Copy S3 file GCP fallback to buffer copy in case GCP returned Internal Error with GATEWAY_TIMEOUT HTTP error code.

[kitaisreal]

Sometimes during CopyObject request in GCP error can be like this:

AWSClient: Response status: 413, Request Entity Too Large
AWSClient: AWSErrorMarshaller: Encountered Unknown AWSError 'EntityTooLarge': Copy spanning locations and/or storage classes could not complete within 30 seconds.
Please use the Rewrite method in the JSON API (https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite) instead.
AWSClient: AWSXmlClient: HTTP response code: 413
Resolved remote host IP address: storage.googleapis.com:443
Request ID:
Exception name: EntityTooLarge
Error message: Unable to parse ExceptionName: EntityTooLarge Message: Copy spanning locations and/or storage classes could not complete within 30 seconds.
Please use the Rewrite method in the JSON API (https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite) instead.
7 response headers:
connection : close
content-length : 306
content-type : application/xml; charset=UTF-8
date : Mon, 19 Feb 2024 12:39:17 GMT
server : UploadServer
vary : Origin

And this looks right according to documentation https://cloud.google.com/storage/docs/json_api/v1/status-codes#413_Payload_Too_Large.

But sometimes error can be like this, and in documentation it is not specified that GATEWAY_TIMEOUT can be returned during CopyObject request https://cloud.google.com/storage/docs/json_api/v1/status-codes#504_Gateway_Timeout.

2024.02.20 08:45:25.972085 [ 435636 ] {} <Information> AWSClient: Response status: 504, Gateway Timeout
2024.02.20 08:45:25.972212 [ 435636 ] {} <Information> AWSClient: AWSErrorMarshaller: Encountered AWSError 'InternalError': Copy spanning locations and/or storage classes could not complete within 30 seconds. Please use the Rewrite method in the JSON API (https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite) instead.
2024.02.20 08:45:25.972273 [ 435636 ] {} <Information> AWSClient: AWSXmlClient: HTTP response code: 504
Resolved remote host IP address: storage.googleapis.com:443
Request ID:
Exception name: InternalError
Error message: Copy spanning locations and/or storage classes could not complete within 30 seconds.
Please use the Rewrite method in the JSON API (https://cloud.google.com/storage/docs/json_api/v1/objects/rewrite) instead.
7 response headers:
connection : close
content-length : 400
content-type : application/xml; charset=UTF-8
date : Tue, 20 Feb 2024 08:45:25 GMT
server : UploadServer

Maybe we can somehow better understand this specific case, and properly fallback to buffer copy.

[robot-ch-test-poll3]

This is an automated comment for commit 25bfcdd with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

[antonio2368]

I think this is related to this issue #59660 (comment)
Fallback is okay for now, but to avoid heavy reads/writes on copy we can support rewrite from GCS' JSON API which contains rewriteToken so a copy is chunked similarly as for multipart copy in S3.

[kitaisreal]

I think this is related to this issue #59660 (comment) Fallback is okay for now, but to avoid heavy reads/writes on copy we can support rewrite from GCS' JSON API which contains rewriteToken so a copy is chunked similarly as for multipart copy in S3.

Totally agree, we need to support rewrite.

[vitlibar]

Checking for GATEWAY_TIMEOUT doesn't seem completely correct because it can mean something else.
Can we check something else to identify that kind of response?

[vitlibar]

For example, we could search in the response for this text use the Rewrite method in the JSON API instead.

[kitaisreal]

Agree. I think we need to change this check a bit.
But I am not sure if check for some specific substring in error message is okay.
@antonio2368 What do you think ?

[antonio2368]

hmm I agree with @vitlibar, we would risk fallback to heavy operation instead of simply retrying the copy if the error can be avoided by a simple retry.
and both the code and exception name seem generic so we would have to search in the respones

[kitaisreal]

Updated.

[KochetovNicolai]

test_backup_restore_s3/test.py::test_user_specific_auth is flaky

test_replicated_database/test.py::test_startup_without_zk is flaky

test_replicated_table_attach/test.py::test_startup_with_small_bg_pool_partitioned is flaky

00984_parser_stack_overflow is flaky