Ulid short circuit

[jlmadurga]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Short circuit execution for ULIDStringToDateTime

[robot-ch-test-poll1]

This is an automated comment for commit 28eb159 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending

[Algunenano]

toDateTime probably needs a timezone too: https://s3.amazonaws.com/clickhouse-test-reports/60211/af14343462b10828fc0e6b9eac03590a42956546/stateless_tests__aarch64_.html

2024-02-21 19:41:28 --- /usr/share/clickhouse-test/queries/0_stateless/02995_ulid_short_circuit.reference	2024-02-21 19:32:56.232416132 +0300
2024-02-21 19:41:28 +++ /tmp/clickhouse-test/0_stateless/02995_ulid_short_circuit.stdout	2024-02-21 19:41:28.112429839 +0300
2024-02-21 19:41:28 @@ -1,2 +1,2 @@
2024-02-21 19:41:28  2024-02-20 16:53:57.105
2024-02-21 19:41:28 -2024-02-21 12:00:00.000
2024-02-21 19:41:28 +2024-02-21 10:00:00.000
2024-02-21 19:41:28 
2024-02-21 19:41:28 
2024-02-21 19:41:28 Settings used in the test: --max_insert_threads 0 --group_by_two_level_threshold 1000000 --group_by_two_level_threshold_bytes 30666637 --distributed_aggregation_memory_efficient 1 --fsync_metadata 1 --output_format_parallel_formatting 0 --input_format_parallel_parsing 0 --min_chunk_bytes_for_parallel_parsing 2967097 --max_read_buffer_size 1022899 --prefer_localhost_replica 0 --max_block_size 40966 --max_threads 33 --optimize_append_index 1 --optimize_if_chain_to_multiif 0 --optimize_if_transform_strings_to_enum 0 --optimize_read_in_order 1 --optimize_or_like_chain 1 --optimize_substitute_columns 0 --enable_multiple_prewhere_read_steps 1 --read_in_order_two_level_merge_threshold 16 --optimize_aggregation_in_order 0 --aggregation_in_order_max_block_bytes 22531778 --min_compress_block_size 2418609 --max_compress_block_size 1941249 --use_uncompressed_cache 1 --min_bytes_to_use_direct_io 5924730389 --min_bytes_to_use_mmap_io 1 --local_filesystem_read_method io_uring --remote_filesystem_read_method threadpool --local_filesystem_read_prefetch 1 --filesystem_cache_segments_batch_size 10 --read_from_filesystem_cache_if_exists_otherwise_bypass_cache 0 --throw_on_error_from_cache_on_write_operations 0 --remote_filesystem_read_prefetch 0 --allow_prefetched_read_pool_for_remote_filesystem 1 --filesystem_prefetch_max_memory_usage 128Mi --filesystem_prefetches_limit 0 --filesystem_prefetch_min_bytes_for_single_read_task 1Mi --filesystem_prefetch_step_marks 50 --filesystem_prefetch_step_bytes 100Mi --compile_aggregate_expressions 0 --compile_sort_description 0 --merge_tree_coarse_index_granularity 31 --optimize_distinct_in_order 0 --max_bytes_before_external_sort 10737418240 --max_bytes_before_external_group_by 8831025856 --max_bytes_before_remerge_sort 347721009 --optimize_sorting_by_input_stream_properties 0 --http_response_buffer_size 7932347 --http_wait_end_of_query True --enable_memory_bound_merging_of_aggregation_results 1 --min_count_to_compile_expression 3 --min_count_to_compile_aggregate_expression 3 --min_count_to_compile_sort_description 0 --session_timezone Asia/Qatar
2024-02-21 19:41:28 
2024-02-21 19:41:28 MergeTree settings used in test: --ratio_of_defaults_for_sparse_serialization 1.0 --prefer_fetch_merged_part_size_threshold 10737418240 --vertical_merge_algorithm_min_rows_to_activate 1000000 --vertical_merge_algorithm_min_columns_to_activate 100 --allow_vertical_merges_from_compact_to_wide_parts 0 --min_merge_bytes_to_use_direct_io 10737418240 --index_granularity_bytes 25180644 --merge_max_block_size 1348 --index_granularity 45527 --min_bytes_for_wide_part 1073741824 --marks_compress_block_size 78946 --primary_key_compress_block_size 71537 --replace_long_file_name_to_hash 1 --max_file_name_length 120
2024-02-21 19:41:28 
2024-02-21 19:41:28 Database: test_vtf20tvf

[jrdi]

Looks like you were hit by the io_uring issue in the CI (see #60373). Rebase with master.

[jlmadurga]

@Algunenano is there anything I can do for the failed Bugfix validation?

Still two queued jobs but mostly everything passed.

[Algunenano]

is there anything I can do for the failed Bugfix validation?

It seems the check itself is broken. because the test do reproduce the issue. Nevertheless, I'm switching the PR to improvement since short circuit on functions is a feature