Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #49660 to 23.3: Fix reading from sparse columns after restart #60246

Conversation

robot-clickhouse-ci-1
Copy link
Contributor

Original pull-request #49660

This pull-request is a first step of an automated backporting.
It contains changes similar to calling git cherry-pick locally.
If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.

Note

This pull-request will be merged automatically. Please, do not merge it manually (but if you accidentally did, nothing bad will happen).

Troubleshooting

If the PR was manually reopened after being closed

If this PR is stuck (i.e. not automatically merged after one day), check #49660 for pr-backports-created label and delete it.

Manually merging will do nothing. The pr-backports-created label prevents the original PR #49660 from being processed.

If the conflicts were resolved in a wrong way

If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:

  • delete the pr-cherrypick label from the PR
  • delete this branch from the repository

You also need to check the original PR #49660 for pr-backports-created, and delete if it's presented there

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! do not test disable testing on pull request labels Feb 21, 2024
@robot-clickhouse-ci-1
Copy link
Contributor Author

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h2m43s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-ch-test-poll4
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h0m33s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-clickhouse-ci-2
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h59m4s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-clickhouse-ci-2
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h58m11s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-ch-test-poll
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h3m22s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-clickhouse-ci-2
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h23m30s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-clickhouse
Copy link
Member

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h4m13s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-ch-test-poll3
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h18m9s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-ch-test-poll4
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h10m45s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-ch-test-poll
Copy link
Contributor

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h0m52s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@robot-clickhouse-ci-1
Copy link
Contributor Author

Dear @alexey-milovidov, @CurtizJ, @kssenii, the PR is not updated for 1d24h59m18s. Please, either resolve the conflicts, or close it to finish the backport process of #49660

@alexey-milovidov alexey-milovidov added the close in a month if not active This will be closed in case of no information label Mar 3, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 merged commit 729b1ce into backport/23.3/49660 Mar 4, 2024
2 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 deleted the cherrypick/23.3/4a4eb5b17100481493005e5d23f437c222e7f362 branch March 4, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close in a month if not active This will be closed in case of no information do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants