New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Check stack size in Parser"" #60434
Merged
alexey-milovidov
merged 4 commits into
master
from
revert-60216-revert-59697-check-stack-size-in-parser
Feb 28, 2024
Merged
Revert "Revert "Check stack size in Parser"" #60434
alexey-milovidov
merged 4 commits into
master
from
revert-60216-revert-59697-check-stack-size-in-parser
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-not-for-changelog
This PR should not be mentioned in the changelog
label
Feb 26, 2024
This is an automated comment for commit 8665c9b with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
…-60216-revert-59697-check-stack-size-in-parser
Algunenano
approved these changes
Feb 27, 2024
alexey-milovidov
deleted the
revert-60216-revert-59697-check-stack-size-in-parser
branch
February 28, 2024 16:20
robot-ch-test-poll1
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-not-for-changelog
This PR should not be mentioned in the changelog
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #60216
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Check for stack overflow in parsers even if the user misconfigured the
max_parser_depth
setting to a very high value. This closes #59622.