Add definers for views (Attempt 2) #60439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/en/operations/settings/settings.md # src/Core/Settings.h
# Conflicts: # docs/en/operations/settings/settings.md # src/Core/Settings.h # src/Processors/Transforms/buildPushingToViewsChain.cpp
# Conflicts: # src/Processors/Transforms/buildPushingToViewsChain.cpp # src/Storages/StorageMaterializedView.cpp
# Conflicts: # docs/en/sql-reference/statements/create/view.md
# Conflicts: # docs/en/operations/settings/settings.md # src/Core/Settings.h # src/Parsers/ASTAlterQuery.cpp # src/Processors/Transforms/buildPushingToViewsChain.cpp
# Conflicts: # src/Processors/Transforms/buildPushingToViewsChain.cpp
# Conflicts: # src/Core/SettingsChangesHistory.h # src/Processors/Transforms/buildPushingToViewsChain.cpp
|
This is an automated comment for commit e0891b9 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page Successful checks
|
vitlibar
approved these changes
Feb 27, 2024
# Conflicts: # src/Core/SettingsChangesHistory.h
robot-ch-test-poll
added
the
pr-synced-to-cloud
|
@pufit, please pay attention to the CI status |
tavplubix
added a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit 330a206.
Algunenano
reviewed
Mar 6, 2024
| user1="user02884_1_$RANDOM$RANDOM" | ||
| user2="user02884_2_$RANDOM$RANDOM" | ||
| user3="user02884_3_$RANDOM$RANDOM" | ||
| db="db02884_$RANDOM$RANDOM" |
There was a problem hiding this comment.
Why isn't this using the database that's created for each test? CLICKHOUSE_DATABASE.
Having it's custom database makes things harder to track and clean up (specially since the test is slow and might be killed in local envs).
There was a problem hiding this comment.
Also we could use this idea even for objects which are not databases:
user2="user2_02884_${CLICKHOUSE_DATABASE}_$RANDOM"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added new syntax which allows to specify definer user in View/Materialized View. This allows to execute selects/inserts from views without explicit grants for underlying tables.
Documentation entry for user-facing changes
Closes #19228
Original PR: #54901