New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to clang-19 #60448
Update to clang-19 #60448
Conversation
This is an automated comment for commit ecbae90 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@@ -185,7 +185,8 @@ inline bool memequalWide(const char * p1, const char * p2, size_t size) | |||
{ | |||
case 3: if (!compare8(p1 + 32, p2 + 32)) return false; [[fallthrough]]; | |||
case 2: if (!compare8(p1 + 16, p2 + 16)) return false; [[fallthrough]]; | |||
case 1: if (!compare8(p1, p2)) return false; | |||
case 1: if (!compare8(p1, p2)) return false; [[fallthrough]]; | |||
default: ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With added no_warning(switch-default)
this change doesn't seem to be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but no problem - let's have this anyway.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for building ClickHouse with clang-19 (master).