Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang build with certain toolchain #6056

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Conversation

amosbird
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

work around an old kernel header bug. Or else

/home/amos/git/chorigin/dbms/src/Common/TaskStatsInfoGetter.cpp:131:14: error: comparison of integers of different signs: 'ssize_t' (aka 'long') and 'unsigned long' [-Werror,-Wsign-compare]
        if (!NLMSG_OK((&header), bytes_received))
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/amos/gentoo/usr/include/linux/netlink.h:97:34: note: expanded from macro 'NLMSG_OK'
#define NLMSG_OK(nlh,len) ((len) >= sizeof(struct nlmsghdr) && \
                            ~~~  ^  ~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

@alexey-milovidov alexey-milovidov merged commit d78bdd3 into ClickHouse:master Jul 18, 2019
@akuzm akuzm added the pr-build Pull request with build/testing/packaging improvement label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants