New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add virtual columns _block_offset
and _data_version
for MergeTree
tables
#60676
Conversation
This is an automated comment for commit 56b3c95 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
ff033c7
to
88d8880
Compare
Test failures are related to new analyzer. |
Hmm, is it intentional that |
@@ -186,6 +186,8 @@ struct Settings; | |||
M(Bool, disable_freeze_partition_for_zero_copy_replication, true, "Disable FREEZE PARTITION query for zero copy replication.", 0) \ | |||
M(Bool, disable_detach_partition_for_zero_copy_replication, true, "Disable DETACH PARTITION query for zero copy replication.", 0) \ | |||
M(Bool, disable_fetch_partition_for_zero_copy_replication, true, "Disable FETCH PARTITION query for zero copy replication.", 0) \ | |||
M(Bool, enable_block_number_column, false, "Enable persisting column _block_number for each row.", 0) ALIAS(allow_experimental_block_number_column) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these settings are not experimental anymore we should randomize them in CI. The last time that detected a number of issues IIRC and we had to remove it #56474
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Randomization was enabled back in #59295. I'll add a new setting there as well.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added persistent virtual column
_block_offset
which stores original number of row in block that was assigned at insert. Persistence of column_block_offset
can be enabled by settingenable_block_offset_column
. Added virtual column_part_data_version
which contains either min block number or mutation version of part. Persistent virtual column_block_number
is not considered experimental anymore.Documentation entry for user-facing changes
Depends on #60205.