Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Invalid storage definition in metadata file" for parameterized views #60708

Merged
merged 1 commit into from Mar 3, 2024
Merged

Fix "Invalid storage definition in metadata file" for parameterized views #60708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Databases/DatabaseOnDisk.cpp
View file
Open in desktop
Expand Up @@ -83,7 +83,13 @@ std::pair<String, StoragePtr> createTableFromAST(
ColumnsDescription columns;
ConstraintsDescription constraints;

if (!ast_create_query.is_dictionary)
bool has_columns = true;
if (ast_create_query.is_dictionary)
has_columns = false;
if (ast_create_query.isParameterizedView())
has_columns = false;

if (has_columns)
{
/// We do not directly use `InterpreterCreateQuery::execute`, because
/// - the database has not been loaded yet;
Expand Down