Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert-select + insert_deduplication_token bug by setting streams to 1 #60745

Merged

Conversation

jrdi
Copy link
Contributor

@jrdi jrdi commented Mar 4, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix the issue causing undesired deduplication on insert-select queries passing a custom insert_deduplication_token. The change sets streams to 1 in those cases to prevent the issue from happening at the expense of ignoring max_insert_threads > 1

Related to #60746

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 4, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Mar 4, 2024

This is an automated comment for commit b4e90e5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@jrdi jrdi force-pushed the insert-select-deduplication-bug-reproducer branch from 87a4054 to 1da1bbe Compare March 4, 2024 13:39
@jrdi
Copy link
Contributor Author

jrdi commented Mar 4, 2024

After adding changes to prevent the issue, I have changed the PR from not for changelog to bug fix.

@jrdi jrdi changed the title Reproducer for insert-select + insert_deduplication_token bug Fix insert-select + insert_deduplication_token bug by setting streams to 1 Mar 4, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Mar 4, 2024
@jrdi jrdi force-pushed the insert-select-deduplication-bug-reproducer branch from 0bea2be to b72507f Compare March 4, 2024 15:17
@kitaisreal kitaisreal self-assigned this Mar 4, 2024
@kitaisreal kitaisreal requested a review from nickitat March 4, 2024 18:50
@nickitat nickitat self-assigned this Mar 4, 2024
Copy link
Member

@nickitat nickitat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry doesn't mention what is the "issue" specifically

@jrdi jrdi force-pushed the insert-select-deduplication-bug-reproducer branch from e4676e4 to ad1eead Compare March 5, 2024 08:08
@jrdi jrdi force-pushed the insert-select-deduplication-bug-reproducer branch from ad1eead to 5b586f3 Compare March 5, 2024 11:43
@jrdi jrdi force-pushed the insert-select-deduplication-bug-reproducer branch from 5b586f3 to b4e90e5 Compare March 5, 2024 13:47
@jrdi
Copy link
Contributor Author

jrdi commented Mar 6, 2024

@nickitat nickitat merged commit f4fd4e6 into ClickHouse:master Mar 6, 2024
252 of 257 checks passed
@jrdi jrdi deleted the insert-select-deduplication-bug-reproducer branch March 6, 2024 20:11
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants