New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix insert-select + insert_deduplication_token bug by setting streams to 1 #60745
Fix insert-select + insert_deduplication_token bug by setting streams to 1 #60745
Conversation
This is an automated comment for commit b4e90e5 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
87a4054
to
1da1bbe
Compare
After adding changes to prevent the issue, I have changed the PR from not for changelog to bug fix. |
0bea2be
to
b72507f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry doesn't mention what is the "issue" specifically
e4676e4
to
ad1eead
Compare
tests/queries/0_stateless/03001_insert_threads_deduplication.sql
Outdated
Show resolved
Hide resolved
ad1eead
to
5b586f3
Compare
5b586f3
to
b4e90e5
Compare
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the issue causing undesired deduplication on insert-select queries passing a custom
insert_deduplication_token.
The change sets streams to 1 in those cases to prevent the issue from happening at the expense of ignoringmax_insert_threads > 1
Related to #60746