Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setting custom metadata headers on unsupported multipart upload operations #60748

Conversation

Beetelbrox
Copy link
Contributor

@Beetelbrox Beetelbrox commented Mar 4, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Do not set aws custom metadata x-amz-meta-* headers on UploadPart & CompleteMultipartUpload calls

Fixes #60747

Both UploadPart and CompleteMultipartUpload don't accept custom metadata header so we simply drop them if we attept to add them to the request.

This error only happens when running agains S3 proper and I have no idea how to test it in the CI, as far as I can tell relies on MinIO. Any help on this would be much appreciated.

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

@Beetelbrox Beetelbrox changed the title Do not send metadata headers on unsupported multipart upload operations Prevent setting custom metadata headers on unsupported multipart upload operations Mar 4, 2024
@antaljanosbenjamin antaljanosbenjamin added the can be tested Allows running workflows for external contributors label Mar 4, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 4, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Mar 4, 2024

This is an automated comment for commit e8f4e4e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@CheSema CheSema self-assigned this Mar 4, 2024
@CheSema CheSema merged commit 7102937 into ClickHouse:master Mar 4, 2024
220 of 235 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 4, 2024
@Beetelbrox
Copy link
Contributor Author

Beetelbrox commented Mar 4, 2024

@CheSema Would it be possible to backport this? We have features that depends on this fix and we're blocked until the next CH release to release them.

Thanks!

@CheSema CheSema added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-backport Changes, backported to release branch. Do not use manually - automated use only! labels Mar 4, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Mar 4, 2024
…c80a8e8ac1ab7d8f0d5a8b49d778d

Cherry pick #60748 to 23.8: Prevent setting custom metadata headers on unsupported multipart upload operations
robot-clickhouse added a commit that referenced this pull request Mar 4, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Mar 4, 2024
…5c80a8e8ac1ab7d8f0d5a8b49d778d

Cherry pick #60748 to 23.12: Prevent setting custom metadata headers on unsupported multipart upload operations
robot-clickhouse added a commit that referenced this pull request Mar 4, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Mar 4, 2024
…c80a8e8ac1ab7d8f0d5a8b49d778d

Cherry pick #60748 to 24.1: Prevent setting custom metadata headers on unsupported multipart upload operations
robot-clickhouse added a commit that referenced this pull request Mar 4, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Mar 4, 2024
…c80a8e8ac1ab7d8f0d5a8b49d778d

Cherry pick #60748 to 24.2: Prevent setting custom metadata headers on unsupported multipart upload operations
robot-clickhouse added a commit that referenced this pull request Mar 4, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 4, 2024
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60748 to 24.2: Prevent setting custom metadata headers on unsupported multipart upload operations
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60748 to 24.1: Prevent setting custom metadata headers on unsupported multipart upload operations
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60748 to 23.12: Prevent setting custom metadata headers on unsupported multipart upload operations
@Beetelbrox Beetelbrox deleted the fjurado/dont-add-metadata-headers-to-unsupported-multipart-steps branch April 3, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INSERT INTO s3 function fails to perform multipart upload when setting custom metadata headers
7 participants