Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #60738 to 23.3: Remove nonsense from SQL/JSON #60778

Conversation

robot-clickhouse-ci-1
Copy link
Contributor

Original pull-request #60738

This pull-request is a first step of an automated backporting.
It contains changes similar to calling git cherry-pick locally.
If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.

The check results does not matter at this step - you can safely ignore them.

Note

This pull-request will be merged automatically. Please, do not merge it manually (but if you accidentally did, nothing bad will happen).

Troubleshooting

If the PR was manually reopened after being closed

If this PR is stuck (i.e. not automatically merged after one day), check #60738 for pr-backports-created label and delete it.

Manually merging will do nothing. The pr-backports-created label prevents the original PR #60738 from being processed.

If the conflicts were resolved in a wrong way

If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:

  • delete the pr-cherrypick label from the PR
  • delete this branch from the repository

You also need to check the original PR #60738 for pr-backports-created, and delete if it's presented there

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only! do not test disable testing on pull request labels Mar 4, 2024
@robot-ch-test-poll3
Copy link
Contributor

Dear @alexey-milovidov, @kssenii, the PR is not updated for 1d24h13m3s. Please, either resolve the conflicts, or close it to finish the backport process of #60738

@robot-ch-test-poll3
Copy link
Contributor

Dear @alexey-milovidov, @kssenii, the PR is not updated for 1d24h49m26s. Please, either resolve the conflicts, or close it to finish the backport process of #60738

@robot-ch-test-poll4 robot-ch-test-poll4 merged commit df7a981 into backport/23.3/60738 Mar 6, 2024
2 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 deleted the cherrypick/23.3/bc0cf836685689843f36b1647e8d76e83cceb441 branch March 6, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not test disable testing on pull request pr-cherrypick Cherry-pick of merge-commit before backporting. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants