New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Less contention in the cache, part 1 #61066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-performance
Pull request with some performance improvements
label
Mar 8, 2024
This is an automated comment for commit e7f9928 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@@ -965,8 +966,10 @@ void FileSegment::increasePriority() | |||
auto it = getQueueIterator(); | |||
if (it) | |||
{ | |||
auto cache_lock = cache->lockCache(); | |||
hits_count = it->increasePriority(cache_lock); | |||
if (auto cache_lock = cache->tryLockCache()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method should be named tryIncreasePriority
then?
nikitamikhaylov
approved these changes
Mar 8, 2024
kssenii
approved these changes
Mar 8, 2024
robot-ch-test-poll
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created-cloud
pr-must-backport-cloud
pr-performance
Pull request with some performance improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Operations with the filesystem cache will suffer less from the lock contention.