New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the argument order for locate
compatible with MySQL
#61092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-backward-incompatible
Pull request with backwards incompatible changes
label
Mar 8, 2024
This is an automated comment for commit 9546370 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
rschu1ze
changed the title
Fixes #61051
Make the argument order for Mar 8, 2024
locate
compatible with MySQL
antonio2368
approved these changes
Mar 18, 2024
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 18, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backward-incompatible
Pull request with backwards incompatible changes
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61051
External tools expect
locate
to behave like in MySQL, i.e. argument orderneedle
/haystack
. The function was previously an alias ofposition
with argument orderhaystack
-needle
.The situation in other databases is unfortunately messy.
CHARINDEX
but knows neither aboutposition
norlocate
.CHARINDEX
, noposition
/locate
)locate(needle, haystack)
andposition
as an alias with the same argument order. DB2 offers the same semantics.position(needle IN haystack)
.locate(haystack, needle)
.This PR makes
locate
a standalone function (with orderneedle
/haystack
), and allows to go back to the old behavior using settingfunction_locate_has_mysql_compatible_argument_order = 0
. While this is a behavior change, I hope that not too many users actually used thelocate
compatibility alias.A less intrusive alternative to this PR would be to change the behavior only for connection through ClickHouse's MySQL interface. The downside will be that it creates even more confusion (different results for the same statement when executed through native vs. MySQL connection). Also, we'd need to stick with this forever (in contrast to temporary workarounds for MySQL connections like #60365)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
To increase compatibility with MySQL, function
locate
now accepts arguments(needle, haystack[, start_pos])
by default. The previous behavior(haystack, needle, [, start_pos])
can be restored by settingfunction_locate_has_mysql_compatible_argument_order = 0
.