Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lazy execution of default argument in dictGetOrDefault for RangeHashedDictionary #61196

Merged
merged 3 commits into from Mar 13, 2024
Merged

Fix lazy execution of default argument in dictGetOrDefault for RangeHashedDictionary #61196

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b055c3
Use assert_cast to prevent nullptr dereference on bad column types in…
Avogar Mar 11, 2024
0b58848
Fix lazy execution in dictGetOrDefault for RangeHashedDictionary
Avogar Mar 12, 2024
07ee777
Restart CI
Avogar Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Functions/FunctionsConversion.h
View file
Open in desktop
Expand Up @@ -4561,7 +4561,7 @@ arguments, result_type, input_rows_count); \

if (from_low_cardinality)
{
const auto * col_low_cardinality = typeid_cast<const ColumnLowCardinality *>(arguments[0].column.get());
const auto * col_low_cardinality = assert_cast<const ColumnLowCardinality *>(arguments[0].column.get());
Avogar marked this conversation as resolved.
Show resolved Hide resolved

if (skip_not_null_check && col_low_cardinality->containsNull())
throw Exception(ErrorCodes::CANNOT_INSERT_NULL_IN_ORDINARY_COLUMN, "Cannot convert NULL value to non-Nullable type");
Expand All @@ -4586,7 +4586,7 @@ arguments, result_type, input_rows_count); \
if (to_low_cardinality)
{
auto res_column = to_low_cardinality->createColumn();
auto * col_low_cardinality = typeid_cast<ColumnLowCardinality *>(res_column.get());
auto * col_low_cardinality = assert_cast<ColumnLowCardinality *>(res_column.get());

if (from_low_cardinality && !src_converted_to_full_column)
{
Expand Down