Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible incorrect result of aggregate function uniqExact #61257

Merged
merged 4 commits into from Mar 15, 2024

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Mar 12, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix possible incorrect result of aggregate function uniqExact.

@CurtizJ CurtizJ added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Mar 12, 2024
@CurtizJ
Copy link
Member Author

CurtizJ commented Mar 12, 2024

The issue was that #57872 introduced an optimization that calls addBatchSinglePlace instead of addBatch. But it's not applicable for uniqExact function with parallel merging (optimization implemented in #43072). So let's just disable the first optimization for uniqExact (addBatchSinglePlace and addBatch doesn't differ much in performance for uniqExact anyway).

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 12, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Mar 12, 2024

This is an automated comment for commit e418f24 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Avogar Avogar self-assigned this Mar 12, 2024
@CurtizJ
Copy link
Member Author

CurtizJ commented Mar 14, 2024

Profile event AggregationProcessedBlocks slowed down test aggregation_by_partitions, so I removed it.

@CurtizJ CurtizJ merged commit e50ebe1 into ClickHouse:master Mar 15, 2024
228 of 234 checks passed
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 15, 2024
robot-ch-test-poll added a commit that referenced this pull request Mar 15, 2024
…647b50dd3d8f1ecaa80451b8986bd3

Cherry pick #61257 to 23.12: Fix possible incorrect result of aggregate function `uniqExact`
robot-clickhouse added a commit that referenced this pull request Mar 15, 2024
robot-ch-test-poll added a commit that referenced this pull request Mar 15, 2024
…47b50dd3d8f1ecaa80451b8986bd3

Cherry pick #61257 to 24.1: Fix possible incorrect result of aggregate function `uniqExact`
robot-clickhouse added a commit that referenced this pull request Mar 15, 2024
robot-ch-test-poll added a commit that referenced this pull request Mar 15, 2024
…47b50dd3d8f1ecaa80451b8986bd3

Cherry pick #61257 to 24.2: Fix possible incorrect result of aggregate function `uniqExact`
robot-clickhouse added a commit that referenced this pull request Mar 15, 2024
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 15, 2024
robot-ch-test-poll2 added a commit that referenced this pull request Mar 15, 2024
Backport #61257 to 23.12: Fix possible incorrect result of aggregate function `uniqExact`
robot-ch-test-poll2 added a commit that referenced this pull request Mar 15, 2024
Backport #61257 to 24.2: Fix possible incorrect result of aggregate function `uniqExact`
robot-ch-test-poll4 added a commit that referenced this pull request Mar 15, 2024
Backport #61257 to 24.1: Fix possible incorrect result of aggregate function `uniqExact`
@adrian17
Copy link

adrian17 commented Apr 3, 2024

I think we've just hit this issue (wrong uniqExact results, setting min_hit_rate_to_use_consecutive_keys_optimization=1.1 fixes it).

Is there any chance that we'd see a new 24.2 series release with the backported fix?
For now we've going to disable the optimization with the setting above, but we'd rather stay on a 24.2 series for a while longer instead of immediately bumping to 24.3 LTS (as we've seen some minor issues on it, didn't get to report them yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants