New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CREATE OR REPLACE DICTIONARY #61356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 15, 2024 09:59
706734c
to
29f5aed
Compare
vitlibar
added
pr-bugfix
Pull request with bugfix, not backported by default
and removed
do not test
disable testing on pull request
labels
Mar 15, 2024
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 15, 2024 10:01
29f5aed
to
234f711
Compare
This is an automated comment for commit 29a5241 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page
Successful checks
|
vitlibar
force-pushed
the
fix-replace-dictionary
branch
2 times, most recently
from
March 15, 2024 10:43
a99229b
to
347ea28
Compare
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 15, 2024 11:03
347ea28
to
c1554c9
Compare
…every dictionary during CREATE OR REPLACE even if the dictionary is not loaded yet or loading right now.
…on is generated to allow ExternalLoader::reloadConfig() work for generated configurations too.
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 17, 2024 11:11
c1554c9
to
0620d8d
Compare
…ictionary and ExternalDictionariesLoader). Always create a new configuration when we need to modify it.
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 18, 2024 16:22
0620d8d
to
efab496
Compare
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 19, 2024 01:56
efab496
to
c8375cd
Compare
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 19, 2024 21:07
052f78f
to
2f4b9b3
Compare
SmitaRKulkarni
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failures seem unrelated: |
vitlibar
force-pushed
the
fix-replace-dictionary
branch
from
March 21, 2024 15:33
1ec6753
to
29a5241
Compare
robot-ch-test-poll3
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category:
Changelog entry:
This PR fixes
CREATE OR REPLACE DICTIONARY
withlazy_load
turned off.