Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CREATE OR REPLACE DICTIONARY #61356

Merged
merged 9 commits into from Mar 21, 2024

Conversation

vitlibar
Copy link
Member

Changelog category:

  • Bug Fix

Changelog entry:

This PR fixes CREATE OR REPLACE DICTIONARY with lazy_load turned off.

@vitlibar vitlibar marked this pull request as draft March 14, 2024 08:52
@vitlibar vitlibar added the do not test disable testing on pull request label Mar 14, 2024
@SmitaRKulkarni SmitaRKulkarni self-assigned this Mar 14, 2024
@vitlibar vitlibar added pr-bugfix Pull request with bugfix, not backported by default and removed do not test disable testing on pull request labels Mar 15, 2024
@vitlibar vitlibar marked this pull request as ready for review March 15, 2024 10:00
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Mar 15, 2024

This is an automated comment for commit 29a5241 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@vitlibar vitlibar force-pushed the fix-replace-dictionary branch 2 times, most recently from a99229b to 347ea28 Compare March 15, 2024 10:43
…every dictionary during CREATE OR REPLACE

even if the dictionary is not loaded yet or loading right now.
…on is generated

to allow ExternalLoader::reloadConfig() work for generated configurations too.
…ictionary and ExternalDictionariesLoader).

Always create a new configuration when we need to modify it.
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitlibar vitlibar merged commit 1acc0eb into ClickHouse:master Mar 21, 2024
8 of 10 checks passed
@vitlibar vitlibar deleted the fix-replace-dictionary branch March 21, 2024 15:45
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants