Forbid SimpleAggregateFunction in ORDER BY of MergeTree tables #61399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-backward-incompatible
|
This is an automated comment for commit 8936528 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
azat
changed the title
azat
force-pushed
the
order-by-SimpleAggregateFunction
branch
2 times, most recently
from
d28b930
to
9bf34c3
Compare
|
Thank you, this is a good change! |
azat
force-pushed
the
order-by-SimpleAggregateFunction
branch
from
47dd684
to
89eaa3c
Compare
azat
changed the title
azat
force-pushed
the
order-by-SimpleAggregateFunction
branch
from
89eaa3c
to
8b77f4e
Compare
alexey-milovidov
approved these changes
Mar 19, 2024
Will try a rebase. UPD: though it looks like it fails in lots of PRs |
Like AggregateFunction is forbidden, but they are forbidden because they are not comparable. New setting (allow_suspicious_primary_key) had been added for backard compatiblity (turned OFF by default). Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
order-by-SimpleAggregateFunction
branch
from
8b77f4e
to
11d0b0a
Compare
|
@azat, why don't just fix it? Otherwise, it is wasting resources. |
robot-ch-test-poll4
added
the
pr-synced-to-cloud
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Forbid
SimpleAggregateFunctioninORDER BYofMergeTreetables (likeAggregateFunctionis forbidden, but they are forbidden because they are not comparable) by default (useallow_suspicious_primary_keyto allow them).