New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client -s
argument
#61530
Fix client -s
argument
#61530
Conversation
This is an automated comment for commit 463b90e with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good, I only have two small comments:
- Can we add a test with
-no-secure
also? If it requires additional changes apart from adding a single line to a stateless test, then it might not worth it. - The changelog item I think could be improved to let the users know what the fix about without opening a PR.
The best I can think of is to add |
I was thinking about the same line. Let's try. I think it should succeed, but I can be wrong. |
A link for the reference #59075 |
sadly, fast tests are built w/o netSSL |
Yaaaaaay!
|
Pushed again to see if the bugfix check is fixed in #61607 |
…44ae761a9f496d71a60872f1e11da Cherry pick #61530 to 24.1: Fix client `-s` argument
…44ae761a9f496d71a60872f1e11da Cherry pick #61530 to 24.2: Fix client `-s` argument
Backport #61530 to 24.1: Fix client `-s` argument
Backport #61530 to 24.2: Fix client `-s` argument
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
clickhouse-client -s
argument, it was broken by defining it two times.