New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant #61567
Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant #61567
Conversation
This is an automated comment for commit 5f954e7 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
I think #59986 is a better fix. |
Checked binary from that PR, It doesn't fix logical errors that this PR fixes |
…alyzer-group-by-use-nulls
Fuzzer found more issues with analyzer + group_by_use_nulls + grouping set . Now with optimization
AFAIU when we replace injection function with it's arguments, we will make these arguments |
Ok, if no objections, I will disable |
AST fuzzer (tsan) - #59986 (comment) Related failures: |
And fuzzer finds more and more bugs in analyzer +
And it's not caused by any optimization AFAIU UPD: should be fixed in #61933, let's wait |
And one more:
This one is caused by optimization |
Remaining fuzzer failures should be fixed in #61933 |
…ba711ecb3a8d313fda7f5404b72c0 Cherry pick #61567 to 24.3: Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant
…ouping set + analyzer + materialize/constant
Backport #61567 to 24.3: Fix logical error in group_by_use_nulls + grouping set + analyzer + materialize/constant
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix logical error ''Unexpected return type from materialize. Expected Nullable. Got UInt8' while using group_by_use_nulls with analyzer and materialize/constant in grouping set. Closes #61531
Documentation entry for user-facing changes