New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disallow LowCardinality input type for JSONExtract #61617
Merged
jkartseva
merged 2 commits into
ClickHouse:master
from
jkartseva:json-disallow-low-cardinality
Mar 25, 2024
Merged
disallow LowCardinality input type for JSONExtract #61617
jkartseva
merged 2 commits into
ClickHouse:master
from
jkartseva:json-disallow-low-cardinality
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkartseva
added
the
can be tested
Allows running workflows for external contributors
label
Mar 20, 2024
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Mar 20, 2024
This is an automated comment for commit 8d9a58c with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
Workaraund for a memory corruption issue ClickHouse#61562 It seems that the root cause lies not within the parser itself, but rather either with the Columns/ColumnLowCardinality or Functions/IFunction code paths.
jkartseva
force-pushed
the
json-disallow-low-cardinality
branch
from
March 21, 2024 04:14
58fe16b
to
837193f
Compare
Fix tests and add new ones.
jkartseva
force-pushed
the
json-disallow-low-cardinality
branch
from
March 21, 2024 04:18
837193f
to
8d9a58c
Compare
robot-ch-test-poll4
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 25, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-bugfix
Pull request with bugfix, not backported by default
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for a memory corruption issue
#61562
It seems that the root cause lies not within the parser itself, but rather either with the
Columns/ColumnLowCardinality
orFunctions/IFunction
code paths.Disable the default substitution of LowCardinality columns with nested columns, until the issue is fixed.
Since the type of the column containing JSON is expected to be
String
,ILLEGAL_TYPE_OF_ARGUMENT
is thrown for the LowCardinality type.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Disallow LowCardinality type for the column containing JSON input in the JSONExtract function.
Documentation entry for user-facing changes