New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload certificate chain during certificate reload #61671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickitat
reviewed
Mar 20, 2024
src/Server/CertificateReloader.cpp
Outdated
for (auto cert = current->certs_chain.begin() + 1; cert != current->certs_chain.end(); cert++) { | ||
ret = SSL_add1_chain_cert(ssl, const_cast<X509 *>(cert->certificate())); | ||
if (!ret) | ||
return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
return ret; | |
return ret; |
robot-ch-test-poll1
added
the
pr-improvement
Pull request with some product improvements
label
Mar 20, 2024
This is an automated comment for commit a2ad832 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
tavplubix
added
the
can be tested
Allows running workflows for external contributors
label
Mar 21, 2024
GrigoryPervakov
force-pushed
the
master
branch
5 times, most recently
from
March 25, 2024 12:07
870b1ac
to
bd1c6fa
Compare
nickitat
reviewed
Mar 25, 2024
nickitat
approved these changes
Mar 27, 2024
robot-ch-test-poll
added
the
pr-synced-to-cloud
The PR is synced to the cloud repo
label
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Reload certificate chain during certificate reload
Fixes #47734