Fix crash in multiSearchAllPositionsCaseInsensitiveUTF8 for incorrect UTF-8

[pufit]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash in multiSearchAllPositionsCaseInsensitiveUTF8 when specifying incorrect UTF-8 sequence.
Example: #61714 (comment)

Documentation entry for user-facing changes

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

---

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates

Run only:

• Integration tests
• Integration tests (arm64)
• Stateless tests (release)
• Stateless tests (asan)
• Stateful tests (release)
• Stateful tests (asan)
• No sanitizers
• Tests with analyzer
• Fast tests
• Only package_debug build
• Add your CI variant description here

CI options:

• do not test (only style check)
• disable merge-commit (no merge from master before tests)
• disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

• 1
• 2
• 3
• 4

[robot-clickhouse-ci-2]

This is an automated comment for commit 15883a1 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Bugfix validation	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

[alexey-milovidov]

Also check this:

milovidov@milovidov-desktop:~$ ~/work/ClickHouse/build_msan/programs/clickhouse 
ClickHouse local version 24.3.1.1.

milovidov-desktop :) SHOW SETTINGS ILIKE '%CONNECTOW CHANGED SETTINGS ILI\xBF\xBA\xDF\xD8%bEMORY%';

SHOW SETTINGS ILIKE '%CONNECTOW CHANGED SETTINGS ILI����%bEMORY%'

Query id: fe2e3615-43b5-4fbe-8db9-d12c74f9e2e7

==3115632==WARNING: MemorySanitizer: use-of-uninitialized-value
→ Progress: 997.00 rows, 219.25 KB (613.71 rows/s., 134.96 KB/s.)                                                                                                                                                                                         #0 0x55c6ec8e2ca4 in DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::putNGramBase(unsigned short, int) build_msan/./src/Common/Volnitsky.h:472:16
    #1 0x55c6ec8e2ca4 in DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)::operator()(unsigned short, int) const build_msan/./src/Common/Volnitsky.h:405:101
    #2 0x55c6ec8e2ca4 in bool DB::VolnitskyTraits::putNGramUTF8CaseInsensitive<DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&>(char8_t const*, int, char8_t const*, unsigned long, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&) build_msan/./src/Common/Volnitsky.h:283:21
    #3 0x55c6ec8e2ca4 in bool DB::VolnitskyTraits::putNGram<false, false, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&>(char8_t const*, int, char8_t const*, unsigned long, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&) build_msan/./src/Common/Volnitsky.h:364:20
    #4 0x55c6ec8e2ca4 in DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long) build_msan/./src/Common/Volnitsky.h:410:23
    #5 0x55c6f1509f7e in DB::MatchImpl<DB::(anonymous namespace)::NameILike, (DB::MatchTraits::Syntax)0, (DB::MatchTraits::Case)1, (DB::MatchTraits::Result)0>::vectorConstant(DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, DB::PODArray<unsigned long, 4096ul, Allocator<false, false>, 63ul, 64ul> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, COW<DB::IColumn>::immutable_ptr<DB::IColumn> const&, DB::PODArray<char8_t, 4096ul, Allocator<false, false>, 63ul, 64ul>&, DB::ColumnVector<char8_t>*) build_msan/./src/Functions/MatchImpl.h:235:22
    #6 0x55c6f1509f7e in DB::FunctionsStringSearch<DB::MatchImpl<DB::(anonymous namespace)::NameILike, (DB::MatchTraits::Syntax)0, (DB::MatchTraits::Case)1, (DB::MatchTraits::Result)0>, (DB::ExecutionErrorPolicy)1, (DB::HaystackNeedleOrderIsConfigurable)0>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const build_msan/./src/Functions/FunctionsStringSearch.h:240:13
    #7 0x55c6e86adf97 in DB::FunctionToExecutableFunctionAdaptor::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const build_msan/./src/Functions/IFunctionAdaptors.h:21:26
    #8 0x55c70ed593e9 in DB::IExecutableFunction::executeWithoutLowCardinalityColumns(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const build_msan/./src/Functions/IFunction.cpp:248:15
    #9 0x55c70ed5b313 in DB::IExecutableFunction::executeWithoutSparseColumns(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const build_msan/./src/Functions/IFunction.cpp:303:22
    #10 0x55c70ed61702 in DB::IExecutableFunction::execute(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName>> const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const build_msan/./src/Functions/IFunction.cpp:378:16
    #11 0x55c711970747 in DB::executeAction(DB::ExpressionActions::Action const&, DB::(anonymous namespace)::ExecutionContext&, bool, bool) build_msan/./src/Interpreters/ExpressionActions.cpp:616:60
    #12 0x55c711970747 in DB::ExpressionActions::execute(DB::Block&, unsigned long&, bool, bool) const build_msan/./src/Interpreters/ExpressionActions.cpp:746:13
    #13 0x55c71958afc0 in DB::FilterTransform::doTransform(DB::Chunk&) build_msan/./src/Processors/Transforms/FilterTransform.cpp:276:25
    #14 0x55c71958a7e3 in DB::FilterTransform::transform(DB::Chunk&) build_msan/./src/Processors/Transforms/FilterTransform.cpp:259:5
    #15 0x55c704b18980 in DB::ISimpleTransform::transform(DB::Chunk&, DB::Chunk&) build_msan/./src/Processors/ISimpleTransform.h:32:9
    #16 0x55c718c2e73f in DB::ISimpleTransform::work() build_msan/./src/Processors/ISimpleTransform.cpp:89:9
    #17 0x55c718c98494 in DB::executeJob(DB::ExecutingGraph::Node*, DB::ReadProgressCallback*) build_msan/./src/Processors/Executors/ExecutionThreadContext.cpp:47:26
    #18 0x55c718c98494 in DB::ExecutionThreadContext::executeTask() build_msan/./src/Processors/Executors/ExecutionThreadContext.cpp:95:9
    #19 0x55c718c66ea5 in DB::PipelineExecutor::executeStepImpl(unsigned long, std::__1::atomic<bool>*) build_msan/./src/Processors/Executors/PipelineExecutor.cpp:273:26
    #20 0x55c718c65002 in DB::PipelineExecutor::executeSingleThread(unsigned long) build_msan/./src/Processors/Executors/PipelineExecutor.cpp:239:5
    #21 0x55c718c65002 in DB::PipelineExecutor::executeImpl(unsigned long, bool) build_msan/./src/Processors/Executors/PipelineExecutor.cpp:411:9
    #22 0x55c718c64a67 in DB::PipelineExecutor::execute(unsigned long, bool) build_msan/./src/Processors/Executors/PipelineExecutor.cpp:111:9
    #23 0x55c718ca38c5 in DB::threadFunction(DB::PullingAsyncPipelineExecutor::Data&, std::__1::shared_ptr<DB::ThreadGroup>, unsigned long, bool) build_msan/./src/Processors/Executors/PullingAsyncPipelineExecutor.cpp:83:24
    #24 0x55c718ca38c5 in DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0::operator()() const build_msan/./src/Processors/Executors/PullingAsyncPipelineExecutor.cpp:109:13
    #25 0x55c718ca38c5 in decltype(std::declval<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&>()()) std::__1::__invoke[abi:v15000]<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&) build_msan/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
    #26 0x55c718ca38c5 in decltype(auto) std::__1::__apply_tuple_impl[abi:v15000]<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&, std::__1::tuple<>&>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&, std::__1::tuple<>&, std::__1::__tuple_indices<...>) build_msan/./contrib/llvm-project/libcxx/include/tuple:1789:1
    #27 0x55c718ca38c5 in decltype(auto) std::__1::apply[abi:v15000]<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&, std::__1::tuple<>&>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&, std::__1::tuple<>&) build_msan/./contrib/llvm-project/libcxx/include/tuple:1798:1
    #28 0x55c718ca38c5 in ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'()::operator()() build_msan/./src/Common/ThreadPool.h:223:13
    #29 0x55c718ca38c5 in decltype(std::declval<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>()()) std::__1::__invoke[abi:v15000]<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'()&>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&) build_msan/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
    #30 0x55c718ca38c5 in void std::__1::__invoke_void_return_wrapper<void, true>::__call<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'()&>(ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'()&) build_msan/./contrib/llvm-project/libcxx/include/__functional/invoke.h:479:9
    #31 0x55c718ca38c5 in std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'(), void ()>::operator()[abi:v15000]() build_msan/./contrib/llvm-project/libcxx/include/__functional/function.h:235:12
    #32 0x55c718ca38c5 in void std::__1::__function::__policy_invoker<void ()>::__call_impl<std::__1::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<true>::ThreadFromGlobalPoolImpl<DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0>(DB::PullingAsyncPipelineExecutor::pull(DB::Chunk&, unsigned long)::$_0&&)::'lambda'(), void ()>>(std::__1::__function::__policy_storage const*) build_msan/./contrib/llvm-project/libcxx/include/__functional/function.h:716:16
    #33 0x55c6fec1980e in std::__1::__function::__policy_func<void ()>::operator()[abi:v15000]() const build_msan/./contrib/llvm-project/libcxx/include/__functional/function.h:848:16
    #34 0x55c6fec1980e in std::__1::function<void ()>::operator()() const build_msan/./contrib/llvm-project/libcxx/include/__functional/function.h:1187:12
    #35 0x55c6fec1980e in ThreadPoolImpl<std::__1::thread>::worker(std::__1::__list_iterator<std::__1::thread, void*>) build_msan/./src/Common/ThreadPool.cpp:455:13
    #36 0x55c6fec260b0 in void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()::operator()() const build_msan/./src/Common/ThreadPool.cpp:217:73
    #37 0x55c6fec260b0 in decltype(std::declval<void>()()) std::__1::__invoke[abi:v15000]<void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(void&&) build_msan/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394:23
    #38 0x55c6fec260b0 in void std::__1::__thread_execute[abi:v15000]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>(std::__1::tuple<void, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>&, std::__1::__tuple_indices<...>) build_msan/./contrib/llvm-project/libcxx/include/thread:284:5
    #39 0x55c6fec260b0 in void* std::__1::__thread_proxy[abi:v15000]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void ThreadPoolImpl<std::__1::thread>::scheduleImpl<void>(std::__1::function<void ()>, Priority, std::__1::optional<unsigned long>, bool)::'lambda0'()>>(void*) build_msan/./contrib/llvm-project/libcxx/include/thread:295:5
    #40 0x7fe6d532dac2 in start_thread nptl/pthread_create.c:442:8
    #41 0x7fe6d53bf84f  misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

  Uninitialized value was created by an allocation of 'seq_l112.i.i' in the stack frame
↑ Progress: 997.00 rows, 219.25 KB (447.91 rows/s., 98.50 KB/s.)                                                                                                                                                                                          #0 0x55c6ec8e0fb7 in bool DB::VolnitskyTraits::putNGramUTF8CaseInsensitive<DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&>(char8_t const*, int, char8_t const*, unsigned long, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&) build_msan/./src/Common/Volnitsky.h:272:21
    #1 0x55c6ec8e0fb7 in bool DB::VolnitskyTraits::putNGram<false, false, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&>(char8_t const*, int, char8_t const*, unsigned long, DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long)::'lambda'(unsigned short, int)&) build_msan/./src/Common/Volnitsky.h:364:20
    #2 0x55c6ec8e0fb7 in DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::VolnitskyBase(char const*, unsigned long, unsigned long) build_msan/./src/Common/Volnitsky.h:410:23

SUMMARY: MemorySanitizer: use-of-uninitialized-value build_msan/./src/Common/Volnitsky.h:472:16 in DB::VolnitskyBase<false, false, DB::impl::StringSearcher<false, false>>::putNGramBase(unsigned short, int)
Exiting