Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats #61883

Merged
merged 1 commit into from Apr 3, 2024

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Mar 25, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix skipping escape sequcne parsing errors during JSON data parsing while using input_format_allow_errors_num/ratio settings.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/


Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates

Run only:

  • Integration tests
  • Integration tests (arm64)
  • Stateless tests (release)
  • Stateless tests (asan)
  • Stateful tests (release)
  • Stateful tests (asan)
  • No sanitizers
  • Tests with analyzer
  • Fast tests
  • Only package_debug build
  • Add your CI variant description here

CI options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 25, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Mar 25, 2024

This is an automated comment for commit e22c3f7 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@evillique evillique self-assigned this Mar 25, 2024
@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 28, 2024
@Avogar
Copy link
Member Author

Avogar commented Mar 28, 2024

Let's backport it, there are users who need this fix in previous versions

@Avogar Avogar merged commit bb5ffa6 into ClickHouse:master Apr 3, 2024
192 of 219 checks passed
robot-ch-test-poll1 added a commit that referenced this pull request Apr 3, 2024
…1612865ba893b1bfd95c37c650a45

Cherry pick #61883 to 23.8: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
robot-clickhouse added a commit that referenced this pull request Apr 3, 2024
…arse error to be able to skip it in row input formats
robot-ch-test-poll1 added a commit that referenced this pull request Apr 3, 2024
…1612865ba893b1bfd95c37c650a45

Cherry pick #61883 to 24.1: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
robot-clickhouse added a commit that referenced this pull request Apr 3, 2024
…arse error to be able to skip it in row input formats
robot-ch-test-poll1 added a commit that referenced this pull request Apr 3, 2024
…1612865ba893b1bfd95c37c650a45

Cherry pick #61883 to 24.2: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
robot-clickhouse added a commit that referenced this pull request Apr 3, 2024
…arse error to be able to skip it in row input formats
robot-ch-test-poll1 added a commit that referenced this pull request Apr 3, 2024
…1612865ba893b1bfd95c37c650a45

Cherry pick #61883 to 24.3: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
robot-clickhouse added a commit that referenced this pull request Apr 3, 2024
…arse error to be able to skip it in row input formats
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 3, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 3, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Apr 3, 2024
Backport #61883 to 24.2: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
robot-clickhouse-ci-2 added a commit that referenced this pull request Apr 3, 2024
Backport #61883 to 24.1: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
Avogar added a commit that referenced this pull request Apr 3, 2024
Backport #61883 to 24.3: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
Avogar added a commit that referenced this pull request Apr 3, 2024
Backport #61883 to 23.8: Mark CANNOT_PARSE_ESCAPE_SEQUENCE error as parse error to be able to skip it in row input formats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants