New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use keywords structure in all places - obfuscateQueries.cpp
/ Suggest.cpp
#62000
Conversation
This is an automated comment for commit a3e746c with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
AST Fuzzer (TSAN) - #63006 |
@@ -82,6 +60,7 @@ static String getLoadSuggestionQuery(Int32 suggestion_limit, bool basic_suggesti | |||
add_column("name", "data_type_families", false, {}); | |||
add_column("name", "merge_tree_settings", false, {}); | |||
add_column("name", "settings", false, {}); | |||
add_column("keyword", "keywords", false, {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks completion for older servers, can we add this to the query only if the reversion/version is new enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use
system.keywords
to fill in the suggestions and also use them in the all places internally.