-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support minmax index for pointInPolygon
#62085
Open
JackyWoo
wants to merge
16
commits into
ClickHouse:master
Choose a base branch
from
JackyWoo:support_minmax_index_for_pointInPolygon
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support minmax index for pointInPolygon
#62085
JackyWoo
wants to merge
16
commits into
ClickHouse:master
from
JackyWoo:support_minmax_index_for_pointInPolygon
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyWoo
force-pushed
the
support_minmax_index_for_pointInPolygon
branch
from
March 29, 2024 08:01
5b47458
to
e7c8980
Compare
alexey-milovidov
added
the
can be tested
Allows running workflows for external contributors
label
Mar 29, 2024
robot-ch-test-poll
added
the
pr-performance
Pull request with some performance improvements
label
Mar 29, 2024
This is an automated comment for commit f1ffcf0 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
JackyWoo
force-pushed
the
support_minmax_index_for_pointInPolygon
branch
from
April 2, 2024 09:17
5c1d53d
to
82dcf15
Compare
Tests |
|
@alexey-milovidov may I ask someone to review the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-performance
Pull request with some performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
This PR tries to fix #58227
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
pointInPolygon
There are 2 algorithms.
Algorithm 1:
There are 2 kinds of polygons:
Polygon by minmax index:
For hyperactangle [1, 2] × [3, 4] we can create a polygon with 4 points: (1, 3), (1, 4), (2, 4), (2, 3)
Algorithm:
Check whether there is any intersection of the 2 polygons. If true return {true, true}, else return {false, true}.
Algorithm 2:
There are 2 kinds of hyperactangle:
hyperactangle provided by user :
Build by polygon which has 2 columns, the first one represent the range of coordinate_x and the second is for coordinate_y.
For example we can get hyperactangle [0, 1], [0, 1] from polygon [(0, 1), (1, 0), (1, 1)].
Algorithm:
check whether there is any intersection of the two ranges in the two hyperactangle.
Now the PR takes the first one.
Documentation entry for user-facing changes
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: