Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minmax index for pointInPolygon #62085

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

JackyWoo
Copy link
Contributor

@JackyWoo JackyWoo commented Mar 29, 2024

Changelog category (leave one):

  • Performance Improvement

This PR tries to fix #58227

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Support minmax index for pointInPolygon

There are 2 algorithms.

Algorithm 1:

There are 2 kinds of polygons:

  1. by minmax index
  2. provided by user

Polygon by minmax index:
For hyperactangle [1, 2] × [3, 4] we can create a polygon with 4 points: (1, 3), (1, 4), (2, 4), (2, 3)

Algorithm:
Check whether there is any intersection of the 2 polygons. If true return {true, true}, else return {false, true}.

Algorithm 2:

There are 2 kinds of hyperactangle:

  1. by minmax index
  2. provided by user

hyperactangle provided by user :
Build by polygon which has 2 columns, the first one represent the range of coordinate_x and the second is for coordinate_y.
For example we can get hyperactangle [0, 1], [0, 1] from polygon [(0, 1), (1, 0), (1, 1)].

Algorithm:
check whether there is any intersection of the two ranges in the two hyperactangle.

Now the PR takes the first one.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/


Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@JackyWoo JackyWoo force-pushed the support_minmax_index_for_pointInPolygon branch from 5b47458 to e7c8980 Compare March 29, 2024 08:01
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Mar 29, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-performance Pull request with some performance improvements label Mar 29, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Mar 29, 2024

This is an automated comment for commit f1ffcf0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@JackyWoo JackyWoo force-pushed the support_minmax_index_for_pointInPolygon branch from 5c1d53d to 82dcf15 Compare April 2, 2024 09:17
@JackyWoo
Copy link
Contributor Author

JackyWoo commented Apr 7, 2024

Tests array_reduce and 00014_filtering_arrays are flaky

@JackyWoo
Copy link
Contributor Author

02581_share_big_sets_between_multiple_mutations_tasks_long may be flaky.

@JackyWoo
Copy link
Contributor Author

@alexey-milovidov may I ask someone to review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyCondition should analyze pointInPolygon function to utilize minmax indices.
3 participants